Project

Profile

Help

Story #221

closed

[RFE] Support for relative symlinks of RPMs in yum distributor

Added by dgregor@redhat.com about 9 years ago. Updated about 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Platform Release:
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

++ This bug was initially created as a clone of Bugzilla Bug #1060801 ++

Description of problem:

The yum distributor uses absolute paths for RPM symlinks:

$ ls -l /var/lib/pulp/published/https/repos/foo/
total 16
lrwxrwxrwx. 1 apache apache 178 Feb 3 11:21 abrt-addon-kerneloops-2.1.11-2.el7.x86_64.rpm -> /var/lib/pulp/content/rpm/abrt-addon-kerneloops/2.1.11/2.el7/x86_64/ea5bf1c8708e9bd63b282fe38\
50f9731b2b58ae5af2b6a9742dea17ced12d151/abrt-addon-kerneloops-2.1.11-2.el7.x86_64.rpm
lrwxrwxrwx. 1 apache apache 100 Feb 3 11:12 Packages -> /var/lib/pulp/working/repos/foo/distributors/yum_distributor
drwxr-xr-x. 2 apache apache 4096 Feb 3 11:21 repodata
drwxr-xr-x. 2 apache apache 4096 Feb 3 11:12 repodata.old

It would be helpful to be able to have relative symlinks. For example, if /var/lib/pulp is on an NFS share and mounted at a different mount point on another host. Here is what relative links would look like:

$ ls -l /var/lib/pulp/published/https/repos/foo/
total 16
lrwxrwxrwx. 1 apache apache 182 Feb 3 11:11 abrt-addon-kerneloops-2.1.11-2.el7.x86_64.rpm -> ../../../../../../content/rpm/abrt-addon-kerneloops/2.1.11/2.el7/x86_64/ea5bf1c8708e9bd63b282\
fe3850f9731b2b58ae5af2b6a9742dea17ced12d151/abrt-addon-kerneloops-2.1.11-2.el7.x86_64.rpm
lrwxrwxrwx. 1 apache apache 100 Feb 3 11:12 Packages -> /var/lib/pulp/working/repos/foo/distributors/yum_distributor
drwxr-xr-x. 2 apache apache 4096 Feb 3 11:12 repodata
drwxr-xr-x. 2 apache apache 4096 Feb 3 11:11 repodata.old

--- Additional comment from at 02/03/2014 16:24:50 ---

Created attachment 858698
patch against 2.3 branch

--- Additional comment from at 02/05/2014 20:58:50 ---

In pulp_rpm/src/pulp_rpm/yum_plugin/util.py the patch has a bug. It should be:

source_path = os.path.relpath(source_path, os.path.dirname(symlink_path))


Files

87da09f0b60238e40beccbcd1d1e9ddd (3.59 KB) 87da09f0b60238e40beccbcd1d1e9ddd patch against 2.3 branch dgregor@redhat.com, 02/19/2015 02:12 AM

Also available in: Atom PDF