Project

Profile

Help

Issue #2210

The RPM rsync distributor accepts the remote_units_path in a non-obvious place

Added by Ichimonji10 over 5 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.10.0
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

When one is creating an RPM rsync distributor, one can pass a configuration dict like this:

{
    "distributor_id": "my_rpm_rsync_distributor",
    "distributor_type_id": "rpm_rsync_distributor",
    "distributor_config": {
        "remote": {
            "auth_type": "publickey",
            "ssh_user": "foo",
            "ssh_identity_file": "/home/user/.ssh/id_rsa",
            "host": "192.168.121.1",
            "root": "/home/foo/pulp_root_dir"
        },
        "predistributor_id": "yum_distributor"
    }
}

One of the optional configuration options is remote_units_path. It's a relative path that's joined with the root absolute path.

This option most naturally fits in the "remote" dict. However, Pulp currently expects it in the "distributor_config" dict. Please fix this by either:

  • Accepting the remote_units_path option in the remote dict, or
  • dropping the seemingly-spurious remote dict altogether.

It'd be pretty sweet if this fix could be added into Pulp before 2.10 heads out the door. Otherwise, we'll be left with a backwards-compatibility maintenance headache on our hands.

History

#1 Updated by pcreech over 5 years ago

  • Triaged changed from No to Yes

#2 Updated by mhrivnak over 5 years ago

Pulp 3 will flatten configs anyway, so getting rid of the nested dict now would be a fine solution.

#3 Updated by bmbouter over 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#4 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF