Project

Profile

Help

Issue #2207

2 broken unit tests on EL6

Added by dkliban@redhat.com almost 4 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version:
2.10.0
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:

Description

unit.plugins.migration.test_standard_storage_path.TestBatch.test_migrate

Traceback (most recent call last):
  File "/usr/lib64/python2.6/unittest.py", line 278, in run
    testMethod()
  File "/home/jenkins/workspace/unittest-pulp-pr/node-type/rhel6-np/pulp/server/test/unit/plugins/migration/test_standard_storage_path.py", line 139, in test_migrate
    self.assertIn(expected_call, plan.migrate.call_args_list)
AttributeError: 'TestBatch' object has no attribute 'assertIn'

unit.plugins.migration.test_standard_storage_path.TestBatch.test_relink

Traceback (most recent call last):
  File "/usr/lib64/python2.6/unittest.py", line 278, in run
    testMethod()
  File "/home/jenkins/.virtualenvs/test/lib/python2.6/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/home/jenkins/workspace/unittest-pulp-pr/node-type/rhel6-np/pulp/server/test/unit/plugins/migration/test_standard_storage_path.py", line 120, in test_relink
    self.assertIn(link_call, symlink.call_args_list)
AttributeError: 'TestBatch' object has no attribute 'assertIn'

Associated revisions

Revision 9e165202 View on GitHub
Added by semyers almost 4 years ago

Fix tests for py26/el6

I honestly don't remember our support policy for el6 on 2.10, but I do know that we still run unittests on it for PRs, at which point these assertions make el6 always fail.

I also know that we're supposed to have unittest2 on el6, but rather than dig into that I just want to fix this and move on...

History

#1 Updated by pcreech almost 4 years ago

  • Priority changed from Normal to High
  • Severity changed from 2. Medium to 3. High
  • Triaged changed from No to Yes

#2 Updated by semyers over 3 years ago

  • Status changed from NEW to CLOSED - CURRENTRELEASE
  • Assignee set to semyers
  • Tags Easy Fix added

I ninja-fixed this prior to the 2.11 release (see the related commit).

#3 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF