Project

Profile

Help

Issue #2052

reboot_suggested is missing from updateinfo.xml files

Added by Ichimonji10 over 5 years ago. Updated over 2 years ago.

Status:
CLOSED - NOTABUG
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Master
Platform Release:
OS:
Triaged:
No
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Consider the following updateinfo.xml file:

<!-- previous, correct output -->
<?xml version="1.0" encoding="UTF-8"?>
<updates>
    <update from="" status="final" type="pulp" version="6">
        <id>6a5b26e7-d214-4b6d-ae42-f5af0412872b</id>
        <issued date="2015-03-05 05:42:53 UTC" />
        <reboot_suggested>False</reboot_suggested>
        <title>sample title</title>
        <solution>sample solution</solution>
        <description>This sample description contains some non-ASCII characters , such as: 汉堡™, and also contains a long line which some systems may be tempted to wrap.  It will be tested to see if the string survives a round-trip through the API and back out of the yum distributor as XML without any modification.</description>
        <references>
            <reference href="https://example.com/errata/PULP-2017-1234.html" id="PULP-2017:1234" title="PULP-2017:1234" type="self" />
        </references>
        <pkglist>
            <collection>
                <name>pkglist-name</name>
            </collection>
        </pkglist>
    </update>
    <update from="" status="final" type="PULP" version="9">
        <id>3c7c3277-9115-4883-8bba-2731c2d2c7d3</id>
        <issued date="2015-04-05 05:42:53 UTC" />
        <reboot_suggested>False</reboot_suggested>
        <title>no pkglist</title>
        <solution>solution for no pkglist</solution>
        <description>this unit has no packages</description>
        <references />
    </update>
</updates>

This file is well-formed. Importantly for us, each of the <update> elements contains a <reboot_suggested> element.

What value should the <reboot_suggested> element have? According to https://pulp.plan.io/issues/1782:

  • True or False when an uploaded unit specifies whether a reboot should happen.
  • False when an uploaded unit doesn't specify whether a reboot should happen.

Current Pulp 2.9 systems completely omit the <reboot_suggested> element when the uploaded unit doesn't specify whether a reboot should happen. Here's a sample updateinfo.xml file from a current Pulp 2.9 system:

<!-- current, malformed output -->
<?xml version="1.0" encoding="UTF-8"?>
<updates>
    <update from="" status="final" type="pulp" version="6">
        <id>60abbec2-5f5b-4545-8e87-aeeab3aea192</id>
        <issued date="2015-03-05 05:42:53 UTC" />
        <title>sample title</title>
        <solution>sample solution</solution>
        <description>This sample description contains some non-ASCII characters , such as: 汉堡™, and also contains a long line which some systems may be tempted to wrap.  It will be tested to see if the string survives a round-trip through the API and back out of the yum distributor as XML without any modification.</description>
        <references>
            <reference href="https://example.com/errata/PULP-2017-1234.html" id="PULP-2017:1234" title="PULP-2017:1234" type="self" />
        </references>
        <pkglist>
            <collection>
                <name>pkglist-name</name>
            </collection>
        </pkglist>
    </update>
    <update from="" status="final" type="PULP" version="9">
        <id>81233d00-53c9-4704-a43b-6dc9d6feff84</id>
        <issued date="2015-04-05 05:42:53 UTC" />
        <title>no pkglist</title>
        <solution>solution for no pkglist</solution>
        <description>this unit has no packages</description>
        <references />
    </update>
</updates>

History

#1 Updated by Ichimonji10 over 5 years ago

  • Status changed from NEW to CLOSED - NOTABUG

This issue is not valid due to https://pulp.plan.io/issues/2032

#2 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF