https://pulp.plan.io/https://pulp.plan.io/favicon.ico2016-05-04T17:14:58ZPulpRPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113072016-05-04T17:14:58ZIchimonji10jerebear@protonmail.com
<ul></ul><p>Related:</p>
<ul>
<li><a href="https://pulp.plan.io/issues/1432#note-9" class="external">https://pulp.plan.io/issues/1432#note-9</a></li>
<li><a href="https://pulp.plan.io/issues/1792" class="external">https://pulp.plan.io/issues/1792</a></li>
</ul> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113082016-05-04T18:23:51ZIchimonji10jerebear@protonmail.com
<ul></ul><p>Automated test: <a href="https://github.com/PulpQE/pulp-smash/pull/227" class="external">https://github.com/PulpQE/pulp-smash/pull/227</a></p> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113182016-05-05T02:18:28Zmhrivnakmhrivnak@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> set to <i>mhrivnak</i></li></ul><p>I've reproduced, and I know roughly why it's broken. The "unit" instances being passed into the plugin from the platform don't have their "requires" field populated, so it looks like they have no requirements. Now we need to figure out the right way to get that field populated.</p>
<p>This patch fixes it, but is sub-optimal because it causes a new db query for every unit that is getting copied.</p>
<pre><code>diff --git a/plugins/pulp_rpm/plugins/importers/yum/depsolve.py b/plugins/pulp_rpm/plugins/importers/yum/depsolve.py
index 5b81bb6..77211f0 100644
--- a/plugins/pulp_rpm/plugins/importers/yum/depsolve.py
+++ b/plugins/pulp_rpm/plugins/importers/yum/depsolve.py
@@ -433,5 +433,7 @@ class Solver(object):
"""
for segment in paginate(units):
for unit in segment:
+ unit.reload('requires')
for require in unit.requires or []:
yield Requirement(**require)
</code></pre> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113192016-05-05T02:32:55Zmhrivnakmhrivnak@redhat.com
<ul></ul><p>It appears to have broken here: <a href="https://github.com/pulp/pulp_rpm/commit/52efd4c43bf6138334bb9a52c8e98d4d1178e5d7#diff-51b88d515eb899068c7113a46ce0809eL424" class="external">https://github.com/pulp/pulp_rpm/commit/52efd4c43bf6138334bb9a52c8e98d4d1178e5d7#diff-51b88d515eb899068c7113a46ce0809eL424</a></p>
<p>Which has been in place since 2.8.0 GA. Thus this is not a regression in the latest beta.</p> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113202016-05-05T03:00:56Zmhrivnakmhrivnak@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>POST</i></li><li><strong>Platform Release</strong> set to <i>2.8.4</i></li></ul><p><a href="https://github.com/pulp/pulp_rpm/pull/865" class="external">https://github.com/pulp/pulp_rpm/pull/865</a></p> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113352016-05-06T13:49:42Zmhrivnakmhrivnak@redhat.com
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="fixes recursive copy of rpms https://pulp.plan.io/issues/1895 fixes #1895" href="https://pulp.plan.io/projects/pulp_rpm/repository/9/revisions/e67f56dd31fb0e67c0e96df212b3b991daec9388">e67f56dd31fb0e67c0e96df212b3b991daec9388</a>.</p> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=113462016-05-06T14:58:33Zdkliban@redhat.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>High</i></li><li><strong>Severity</strong> changed from <i>2. Medium</i> to <i>3. High</i></li><li><strong>Triaged</strong> changed from <i>No</i> to <i>Yes</i></li></ul> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=117262016-05-25T15:31:38Zpthomas@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>6</i></li></ul><pre><code>[root@ibm-x3550m3-11 ~]# rpm -qa pulp-server
pulp-server-2.8.4-0.1.beta.git.140.69c02ff.el7.noarch
[root@ibm-x3550m3-11 ~]#
[root@ibm-x3550m3-11 ~]# pulp-admin rpm repo create --repo-id source --feed https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/zoo/
Successfully created repository [source]
[root@ibm-x3550m3-11 ~]# pulp-admin rpm repo sync run --repo-id source
+----------------------------------------------------------------------+
Synchronizing Repository [source]
+----------------------------------------------------------------------+
This command may be exited via ctrl+c without affecting the request.
Downloading metadata...
[|]
... completed
Downloading repository content...
[-]
[==================================================] 100%
RPMs: 0/0 items
Delta RPMs: 0/0 items
... completed
Downloading distribution files...
[==================================================] 100%
Distributions: 0/0 items
... completed
Importing errata...
[-]
... completed
Importing package groups/categories...
[-]
... completed
Cleaning duplicate packages...
[-]
... completed
Task Succeeded
Initializing repo metadata
[-]
... completed
Publishing Distribution files
[-]
... completed
Publishing RPMs
[==================================================] 100%
32 of 32 items
... completed
Publishing Delta RPMs
... skipped
Publishing Errata
[==================================================] 100%
4 of 4 items
... completed
Publishing Comps file
[==================================================] 100%
3 of 3 items
... completed
Publishing Metadata.
[-]
... completed
Closing repo metadata
[-]
... completed
Generating sqlite files
... skipped
Publishing files to web
[-]
... completed
Writing Listings File
[-]
... completed
Task Succeeded
[root@ibm-x3550m3-11 ~]# pulp-admin rpm repo create --repo-id target
Successfully created repository [target]
[root@ibm-x3550m3-11 ~]# pulp-admin rpm repo copy rpm --from-repo-id source --to-repo-id target --str-eq="name=chimpanzee" --recursive
This command may be exited via ctrl+c without affecting the request.
[\]
Running...
Copied:
camel-0.1-1-noarch
chimpanzee-0.21-1-noarch
fox-1.1-2-noarch
squirrel-0.1-1-noarch
walrus-5.21-1-noarch
[root@ibm-x3550m3-11 ~]# pulp-admin rpm repo content rpm --repo-id target | grep 'Name:'
Name: squirrel
Name: camel
Name: chimpanzee
Name: walrus
Name: fox
</code></pre> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=119292016-05-31T16:58:12Zsemyerssean.myers@redhat.com
<ul><li><strong>Platform Release</strong> changed from <i>2.8.4</i> to <i>2.8.5</i></li></ul> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=126222016-06-27T16:58:12Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>6</i> to <i>CLOSED - CURRENTRELEASE</i></li></ul> RPM Support - Issue #1895: Recursive RPM unit copies are not recursivehttps://pulp.plan.io/issues/1895?journal_id=389372019-04-15T20:30:54Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul>