Project

Profile

Help

Issue #1820

Fix checking for config.proxy_username

Added by rbarlow over 4 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Nectar:
Platform Release:
2.8.5
Target Release - Nectar:
master
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

We received a GitHub pull request with a fix for this issue before the issue was filed, and the pull request is already merged. I am filing it here as well so we can track that we have an unreleased bug fix.

https://github.com/pulp/nectar/pull/47

The rest of this description is quoted from the pull request.

When using basic authentication for the url to fetch and using a proxy without authentication, all the authentication gets stripped away when the proxy_username exists in the config file /etc/pulp/server/plugins.conf/yum_importer.json but is empty. This is because in threaded.py the code checks if proxy_username == None, which is untrue (it is an empty string). Since

variable = ''
if variable:
do_something
evaluates works as well, this is the better option in my opinion.

History

#1 Updated by amacdona@redhat.com over 4 years ago

  • Triaged changed from No to Yes
  • Tags Documentation added

#2 Updated by semyers over 4 years ago

  • Platform Release changed from 2.8.2 to 2.8.3

#3 Updated by amacdona@redhat.com over 4 years ago

  • Tags deleted (Documentation)

#4 Updated by amacdona@redhat.com over 4 years ago

  • Assignee set to rbarlow

#6 Updated by semyers over 4 years ago

  • Status changed from MODIFIED to 5

#7 Updated by semyers over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#8 Updated by semyers over 4 years ago

  • Status changed from CLOSED - CURRENTRELEASE to MODIFIED
  • Platform Release deleted (2.8.3)

This got caught up in my 2.8.3 release workflow even though it's a nectar change. It looks like 1.5.1 is the latest nectar release, and does not contain this change, so it really is not in 2.8.3. It won't be in any version of pulp until a new version of nectar is built and pulp's dependencies are updated to use it.

#9 Updated by semyers over 4 years ago

  • Platform Release set to 2.8.4

#10 Updated by semyers over 4 years ago

  • Status changed from MODIFIED to 5

#11 Updated by semyers over 4 years ago

  • Platform Release changed from 2.8.4 to 2.8.5

#12 Updated by semyers over 4 years ago

  • Status changed from 5 to MODIFIED

#13 Updated by semyers over 4 years ago

  • Status changed from MODIFIED to 5

#14 Updated by semyers over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#15 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF