Project

Profile

Help

Issue #1782

<reboot_suggested>None</reboot_suggested> in generated XML for unit with no 'reboot_suggested'

Added by rmcgover over 4 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Master
Platform Release:
2.8.3
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 1
Quarter:

Description

If a unit is imported with no top-level 'reboot_suggested' element, then published with yum distributor, the resulting update in updateinfo.xml will contain:

  <reboot_suggested>None</reboot_suggested>

This is dangerous as it's unclear whether consumers would interpret that as true or false.

It would be safer to omit this element from the XML if the unit doesn't specify a value for reboot_suggested.

Associated revisions

Revision 20be9cca View on GitHub
Added by ipanova@redhat.com over 4 years ago

1782 - reboot_suggested is False by default if during unit upload there was not specified any value.

closes #1782 https://pulp.plan.io/issues/1782

History

#1 Updated by mhrivnak over 4 years ago

  • Triaged changed from No to Yes

#2 Updated by Anonymous over 4 years ago

  • Parent task set to #1683

#3 Updated by Anonymous over 4 years ago

  • Sprint/Milestone set to 19

#4 Updated by Anonymous over 4 years ago Private

Verification of this fix will need jluza and rohan to confirm. Have them check the "fixed" metadata so they can confirm that it mirrors what they expect.

#5 Updated by ipanova@redhat.com over 4 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com

#6 Updated by ipanova@redhat.com over 4 years ago

  • Status changed from ASSIGNED to POST

#7 Updated by ipanova@redhat.com over 4 years ago

We decided instead of completely omit reboot_suggested from the XML, make it by default False, if the unit doesn't specify a value for reboot_suggested.

#8 Updated by ipanova@redhat.com over 4 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#9 Updated by ipanova@redhat.com over 4 years ago

  • Platform Release set to 2.8.3

#10 Updated by semyers over 4 years ago

  • Status changed from MODIFIED to 5

#11 Updated by semyers over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#12 Updated by bmbouter over 2 years ago

  • Sprint set to Sprint 1

#13 Updated by bmbouter over 2 years ago

  • Sprint/Milestone deleted (19)

#14 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF