Actions
Issue #1782
closed
<reboot_suggested>None</reboot_suggested> in generated XML for unit with no 'reboot_suggested'
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Master
Platform Release:
2.8.3
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Sprint 1
Quarter:
Description
If a unit is imported with no top-level 'reboot_suggested' element, then published with yum distributor, the resulting update in updateinfo.xml will contain:
<reboot_suggested>None</reboot_suggested>
This is dangerous as it's unclear whether consumers would interpret that as true or false.
It would be safer to omit this element from the XML if the unit doesn't specify a value for reboot_suggested.
Updated by Anonymous almost 7 years ago
Private
Verification of this fix will need jluza and rohan to confirm. Have them check the "fixed" metadata so they can confirm that it mirrors what they expect.
Updated by ipanova@redhat.com almost 7 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to ipanova@redhat.com
Added by ipanova@redhat.com almost 7 years ago
Updated by ipanova@redhat.com almost 7 years ago
- Status changed from ASSIGNED to POST
Updated by ipanova@redhat.com almost 7 years ago
We decided instead of completely omit reboot_suggested from the XML, make it by default False, if the unit doesn't specify a value for reboot_suggested.
Updated by ipanova@redhat.com almost 7 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset 20be9cca41dffbf78651e42eaabaa6b067a2a83c.
Updated by semyers almost 7 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
Actions
.
1782 - reboot_suggested is False by default if during unit upload there was not specified any value.
closes #1782 https://pulp.plan.io/issues/1782