Project

Profile

Help

Issue #1636

Developer oriented error messages have been added as coded exceptions

Added by rbarlow almost 5 years ago. Updated over 1 year ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

A good reason not to put developer errors in the "coded exceptions" is that the coded exceptions need to be well documented and communicated to the users. As these users include our API consumers who may wish to respond to our error code, this will cause them to spend time thinking about how to handle a problem they will never experience. Let's save them the time by just raising a normal boring old Python Exception (or the subclass that makes the most sense). Also, it's probably not necessary to use gettext since working on our code already implies that developers know English enough to read/write our docblocks and comments and variable/function names ☺

We should check for this in all plugins too. We need to do this before we release 2.8.0 because some of these were introduced new in 2.8 and once we release we have to keep it.


Checklist

Associated revisions

Revision db4ded65 View on GitHub
Added by sbhawsin almost 5 years ago

Issue 1636: Developer oriented error messages added as coded exceptions

https://pulp.plan.io/issues/1636

closes #1636

Revision db4ded65 View on GitHub
Added by sbhawsin almost 5 years ago

Issue 1636: Developer oriented error messages added as coded exceptions

https://pulp.plan.io/issues/1636

closes #1636

History

#1 Updated by rbarlow almost 5 years ago

  • Checklist item Review all coded exceptions that are new in 2.8 to see if any are developer oriented. Remove them if they are. added
  • Checklist item Audit all of the plugins for the same. added
  • Checklist item Fix any uses of these errors to use normal Python Exceptions (pick an appropriate one for each case). added

#2 Updated by sbhawsin almost 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to sbhawsin

#3 Updated by bmbouter almost 5 years ago

  • Triaged changed from No to Yes

#5 Updated by sbhawsin almost 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#6 Updated by dkliban@redhat.com almost 5 years ago

  • Status changed from MODIFIED to 5

#7 Updated by dkliban@redhat.com over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#8 Updated by bmbouter over 1 year ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF