Actions
Issue #1495
closedSome Pulp unit tests fail, possibly due to the use of mongoengine 0.10.5 on my dev box
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:
Description
I haven't had time to dig into this, but I've got some test failures that look like this on my dev box:
$ time nosetests -sx server/test/unit/server/db/model/test_dispatch.py
..........F
======================================================================
FAIL: test_set_failed (unit.server.db.model.test_dispatch.TaskStatusTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/fedora/.virtualenvs/pulp/lib/python2.7/site-packages/mock.py", line 1201, in patched
return func(*args, **keywargs)
File "/home/fedora/devel/pulp/server/test/unit/server/db/model/test_dispatch.py", line 1235, in test_set_failed
set__traceback=traceback)
File "/usr/lib/python2.7/site-packages/mongoengine/queryset/base.py", line 516, in update_one
upsert=upsert, multi=False, write_concern=write_concern, **update)
File "/home/fedora/devel/pulp/server/pulp/server/db/querysets.py", line 95, in update
super(CriteriaQuerySet, self).update(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/mongoengine/queryset/base.py", line 450, in update
update = transform.update(queryset._document, **update)
File "/usr/lib/python2.7/site-packages/mongoengine/queryset/transform.py", line 254, in update
value = field.prepare_query_value(op, value)
File "/usr/lib/python2.7/site-packages/mongoengine/fields.py", line 109, in prepare_query_value
return super(StringField, self).prepare_query_value(op, value)
File "/usr/lib/python2.7/site-packages/mongoengine/base/fields.py", line 170, in prepare_query_value
self.validate(value)
File "/home/fedora/devel/pulp/server/pulp/server/db/fields.py", line 27, in validate
self.error(str(e))
File "/usr/lib/python2.7/site-packages/mongoengine/base/fields.py", line 154, in error
raise ValidationError(message, errors=errors, field_name=field_name)
ValidationError: Malformed ISO8601 date-time string: 2014-11-21 05:21:38.829678
bmbouter said he wasn't seeing any failures on his F23 box. I am running F23 but I've pulled in the python-mongoengine-0.10.5 package from Rawhide for testing so it's possible that we need to do something different with that version. This is going to be needed for F24, so I'm going to go ahead and mark this as a 2.8.0 release blocker.
Actions
Fix unit test to use ISO8601 date string
Unit tests had invalid ISO8601 date string, causing tests to fail under mongoengine-0.10
fixes #1495 https://pulp.plan.io/issues/1495