Project

Profile

Help

Issue #1458

closed

Change the Errata model's pushcount field to be IntField

Added by jcline@redhat.com over 8 years ago. Updated almost 5 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Currently, the Errata's pushcount field is a StringField, although pushcount should always be an integer. As part of https://pulp.plan.io/issues/1427 it was changed to an IntField, but this introduced problems with syncing repositories that have errata that do not have a pushcount field. It was difficult to decide on the correct default value (possibly 1, 0, or None). In addition to deciding on a default value, it may be wise to address the code in the distributor that handles publishing the errata.

Particularly, https://github.com/pulp/pulp_rpm/blob/28c520aadffb4f6256681e218477ec4a648fc310/plugins/pulp_rpm/plugins/distributors/yum/metadata/updateinfo.py#L52 is concerning since a default value of 0 causes no pushcount to be published, and a default value of 1 does cause a pushcount to be published.

Also available in: Atom PDF