Project

Profile

Help

Issue #1458

Change the Errata model's pushcount field to be IntField

Added by jcline@redhat.com almost 6 years ago. Updated over 2 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

Currently, the Errata's pushcount field is a StringField, although pushcount should always be an integer. As part of https://pulp.plan.io/issues/1427 it was changed to an IntField, but this introduced problems with syncing repositories that have errata that do not have a pushcount field. It was difficult to decide on the correct default value (possibly 1, 0, or None). In addition to deciding on a default value, it may be wise to address the code in the distributor that handles publishing the errata.

Particularly, https://github.com/pulp/pulp_rpm/blob/28c520aadffb4f6256681e218477ec4a648fc310/plugins/pulp_rpm/plugins/distributors/yum/metadata/updateinfo.py#L52 is concerning since a default value of 0 causes no pushcount to be published, and a default value of 1 does cause a pushcount to be published.

History

#1 Updated by jcline@redhat.com almost 6 years ago

  • Description updated (diff)

#2 Updated by mhrivnak over 5 years ago

  • Triaged changed from No to Yes

#3 Updated by bmbouter over 2 years ago

  • Status changed from NEW to CLOSED - WONTFIX

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

#4 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF