Issue #1449
closed
Users cannot sync v1 content from a registry that implements the v2 API
Description
The current Pulp sync implementation tries to use the remote registry via the v2 API, and if the registry does not implement v2 it falls back to v1. However, if the registry does implement v2, v1 is never tried. Satellite 6 plans to use pulp_docker's sync function instead of Nodes to move content from a parent to a capsule. Due to the current implementation, any repositories that have v1 and v2 content will only be able to mirror v2 content into the capsule.
When fixing this issue, consider whether it would be advantageous or not to make the fallback behavior a boolean option. Not making it optional has the advantage of being simpler (no additional settings needed). Making it optional has the advantage of giving users control in situations where perhaps they only want to use the v2 API and don't want all the images downloaded twice. You are somebody's kid, do what you think is right.
Updated by mhrivnak over 8 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to mhrivnak
- Triaged changed from No to Yes
Added by mhrivnak over 8 years ago
Added by mhrivnak over 8 years ago
Revision d269107e | View on GitHub
Can sync v1 and v2 APIs together, and optionally disable v1 sync
fixes #1449 https://pulp.plan.io/issues/1449
I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.
Added by mhrivnak over 8 years ago
Revision d269107e | View on GitHub
Can sync v1 and v2 APIs together, and optionally disable v1 sync
fixes #1449 https://pulp.plan.io/issues/1449
I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.
Added by mhrivnak over 8 years ago
Revision d269107e | View on GitHub
Can sync v1 and v2 APIs together, and optionally disable v1 sync
fixes #1449 https://pulp.plan.io/issues/1449
I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.
Updated by mhrivnak over 8 years ago
- Status changed from ASSIGNED to POST
- Target Release - Docker set to 2.0.0
Updated by mhrivnak over 8 years ago
- Status changed from POST to MODIFIED
- % Done changed from 0 to 100
Applied in changeset d269107e74982ee7b229f441ad4c91b3a86592c1.
Updated by rbarlow over 8 years ago
- Status changed from MODIFIED to ASSIGNED
This issue also needs to be fixed on the docker_v2_api branch, so I'm sending it back to assigned.
Updated by rbarlow about 8 years ago
- Status changed from ASSIGNED to POST
Hello Tim!
This pull request allows syncing both v1 and v2, but is not able to give detailed progress reporting in doing so:
https://github.com/pulp/pulp_docker/pull/119
Please test this patch and let me know if it is acceptable for your purposes with Pulp 2.6. The upstream pulp-docker-2.0.0 release will be able to give detailed progress reporting and is implemented a little bit differently than is done in this patch.
Added by rbarlow about 8 years ago
Revision 24b1abea | View on GitHub
Sync v1 and v2 content when the registry support it.
pulp-docker used to try v2 and fall back to v1 if v2 was not supported. This commit causes pulp-docker to sync both for registries that support them.
https://pulp.plan.io/issues/1449
re #1449
Added by rbarlow about 8 years ago
Revision 24b1abea | View on GitHub
Sync v1 and v2 content when the registry support it.
pulp-docker used to try v2 and fall back to v1 if v2 was not supported. This commit causes pulp-docker to sync both for registries that support them.
https://pulp.plan.io/issues/1449
re #1449
Updated by rbarlow almost 8 years ago
- Status changed from 5 to CLOSED - CURRENTRELEASE
- Platform Release set to 2.8.0
.
Can sync v1 and v2 APIs together, and optionally disable v1 sync
fixes #1449 https://pulp.plan.io/issues/1449
I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.