Project

Profile

Help

Issue #1449

Users cannot sync v1 content from a registry that implements the v2 API

Added by rbarlow about 5 years ago. Updated almost 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version - Docker:
Platform Release:
2.8.0
Target Release - Docker:
2.0.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The current Pulp sync implementation tries to use the remote registry via the v2 API, and if the registry does not implement v2 it falls back to v1. However, if the registry does implement v2, v1 is never tried. Satellite 6 plans to use pulp_docker's sync function instead of Nodes to move content from a parent to a capsule. Due to the current implementation, any repositories that have v1 and v2 content will only be able to mirror v2 content into the capsule.

When fixing this issue, consider whether it would be advantageous or not to make the fallback behavior a boolean option. Not making it optional has the advantage of being simpler (no additional settings needed). Making it optional has the advantage of giving users control in situations where perhaps they only want to use the v2 API and don't want all the images downloaded twice. You are somebody's kid, do what you think is right.

Associated revisions

Revision d269107e View on GitHub
Added by mhrivnak about 5 years ago

Can sync v1 and v2 APIs together, and optionally disable v1 sync

fixes #1449 https://pulp.plan.io/issues/1449

I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.

Revision d269107e View on GitHub
Added by mhrivnak about 5 years ago

Can sync v1 and v2 APIs together, and optionally disable v1 sync

fixes #1449 https://pulp.plan.io/issues/1449

I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.

Revision d269107e View on GitHub
Added by mhrivnak about 5 years ago

Can sync v1 and v2 APIs together, and optionally disable v1 sync

fixes #1449 https://pulp.plan.io/issues/1449

I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.

Revision d269107e View on GitHub
Added by mhrivnak about 5 years ago

Can sync v1 and v2 APIs together, and optionally disable v1 sync

fixes #1449 https://pulp.plan.io/issues/1449

I combined the root v1 and v2 sync steps into one. The step system requires a single root step, and only one layer of children can report status and progress. This required the refactor, combining each collection of steps onto one parent.

Revision 24b1abea View on GitHub
Added by rbarlow almost 5 years ago

Sync v1 and v2 content when the registry support it.

pulp-docker used to try v2 and fall back to v1 if v2 was not supported. This commit causes pulp-docker to sync both for registries that support them.

https://pulp.plan.io/issues/1449

re #1449

Revision 24b1abea View on GitHub
Added by rbarlow almost 5 years ago

Sync v1 and v2 content when the registry support it.

pulp-docker used to try v2 and fall back to v1 if v2 was not supported. This commit causes pulp-docker to sync both for registries that support them.

https://pulp.plan.io/issues/1449

re #1449

History

#1 Updated by rbarlow about 5 years ago

  • Description updated (diff)

#2 Updated by rbarlow about 5 years ago

  • Priority changed from Normal to High

#3 Updated by mhrivnak about 5 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to mhrivnak
  • Triaged changed from No to Yes

#4 Updated by mhrivnak about 5 years ago

  • Status changed from ASSIGNED to POST
  • Target Release - Docker set to 2.0.0

#5 Updated by mhrivnak about 5 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#6 Updated by rbarlow about 5 years ago

  • Status changed from MODIFIED to ASSIGNED

This issue also needs to be fixed on the docker_v2_api branch, so I'm sending it back to assigned.

#7 Updated by rbarlow about 5 years ago

  • Assignee changed from mhrivnak to rbarlow

#8 Updated by rbarlow almost 5 years ago

  • Status changed from ASSIGNED to POST

Hello Tim!

This pull request allows syncing both v1 and v2, but is not able to give detailed progress reporting in doing so:

https://github.com/pulp/pulp_docker/pull/119

Please test this patch and let me know if it is acceptable for your purposes with Pulp 2.6. The upstream pulp-docker-2.0.0 release will be able to give detailed progress reporting and is implemented a little bit differently than is done in this patch.

#9 Updated by rbarlow almost 5 years ago

  • Status changed from POST to 5

#10 Updated by rbarlow over 4 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
  • Platform Release set to 2.8.0

#11 Updated by bmbouter almost 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF