Project

Profile

Help

Issue #1442

closed

Make RepoURLModifier more IDE-friendly

Added by semyers almost 7 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Low
Assignee:
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
Master
Platform Release:
2.8.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

(and also more developer-friendly)

Currently, in pulp_rpm[0], the RepoURLModifier stashes the passed-in args in a dict as the conf instance attr. This is an artifact from earlier incarnations of that class, and serves no practical purpose. Instead of adding those to a dict, they should be normal instance attributes.

The conf dict keys are used for validation in __call__, but I think it's probably reasonable to get rid of the **kwargs usage in that method to support more IDE- and developer-friendliness; it looks less DRY, but ends up being more explicit and readable, which is probably an overall win.

[0]: https://github.com/pulp/pulp_rpm/blob/0d3a483c905e9c54ebd1ff01ad814fa38f8fb6bb/plugins/pulp_rpm/plugins/importers/yum/utils.py#L105

Actions #1

Updated by mhrivnak almost 7 years ago

  • Triaged changed from No to Yes
Actions #2

Updated by semyers almost 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to semyers

Added by semyers almost 7 years ago

Revision 88881cbf

RepoURLModifier is more IDE- and user-friendly

In addition to explicitly declaring the kwargs to __init__ and __call__, I took a step back and considered if there was any value to storing path_append and ensure_trailing_slash as stateful defaults. Based on the current usage and my best judgement, there was no value in that, and in fact having the same signature for both methods only made things more confusing. Hopefully the stateful nature of of this class is more clear, so in addition to being IDE-friendly, it's much easier for humans to grok.

https://pulp.plan.io/issues/1442 fixes #1442

Actions #3

Updated by semyers almost 7 years ago

  • Status changed from ASSIGNED to POST
  • Version set to Master
Actions #4

Updated by semyers almost 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #5

Updated by rbarlow almost 7 years ago

  • Platform Release set to 2.8.0
Actions #6

Updated by dkliban@redhat.com almost 7 years ago

  • Status changed from MODIFIED to 5
Actions #7

Updated by dkliban@redhat.com over 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE
Actions #8

Updated by bmbouter over 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF