Make RepoURLModifier more IDE-friendly
(and also more developer-friendly)
Currently, in pulp_rpm, the RepoURLModifier stashes the passed-in args in a dict as the
conf instance attr. This is an artifact from earlier incarnations of that class, and serves no practical purpose. Instead of adding those to a dict, they should be normal instance attributes.
The conf dict keys are used for validation in
__call__, but I think it's probably reasonable to get rid of the
**kwargs usage in that method to support more IDE- and developer-friendliness; it looks less DRY, but ends up being more explicit and readable, which is probably an overall win.
RepoURLModifier is more IDE- and user-friendly
In addition to explicitly declaring the kwargs to
__call__, I took a step back and considered if there was any value
ensure_trailing_slash as stateful defaults.
Based on the current usage and my best judgement, there was no value in
that, and in fact having the same signature for both methods only made
things more confusing. Hopefully the stateful nature of of this class is
more clear, so in addition to being IDE-friendly, it's much easier for
humans to grok.
Please register to edit this issue