Issue #1376
closed
Progress report for failed sync contains no errors
Description
It is possible to create an RPM repository with the following parameters:
{
"id": "some random string"
"importer_config": {"feed": "invalid feed url"},
"importer_type_id": "yum_importer",
"notes": {"_repo-type": "rpm-repo"}
}
I can trigger a sync on this repository, and the sync will (correctly) fail. If I read the completed task, the following sections should all be populated with information:
["error"]
["traceback"]
["progress_body"]["yum_importer"]["content"]["error_details"]
However, the "error_details" section is just an empty list, with no errors. This section should be populated, so that users can more easily troubleshoot this issue.
Files
Updated by ipanova@redhat.com over 8 years ago
probably this exact case and situation is related to this https://pulp.plan.io/issues/1382
Updated by mhrivnak over 8 years ago
Can you share the entire data structure from the task status?
Was there a reasonable error reported anywhere in the task status?
Updated by Ichimonji10 over 8 years ago
- File task_body.txt task_body.txt added
mhrivnak wrote:
Can you share the entire data structure from the task status?
Was there a reasonable error reported anywhere in the task status?
Yes, I can share the entire data structure. Due to its length, I've attached it. The most useful piece of information in the `["error"]` section of the response:
'error': {
'code': 'PLP0000',
'data': {},
'description': 'Unsupported scheme: ',
'sub_errors': []
},
Updated by jortel@redhat.com over 8 years ago
- Severity changed from 2. Medium to 3. High
- Triaged changed from No to Yes
Updated by jortel@redhat.com over 7 years ago
- Status changed from NEW to ASSIGNED
- Assignee set to jortel@redhat.com
Updated by jortel@redhat.com over 7 years ago
This fatal error is reported in the correct place. The RPM plugin incorrectly uses the progress report to report other errors. The best we can do for pulp2 is improve the error message itself.
Updated by jortel@redhat.com over 7 years ago
- Status changed from ASSIGNED to POST
Added by jortel@redhat.com about 7 years ago
Updated by jortel@redhat.com about 7 years ago
- Status changed from POST to MODIFIED
Applied in changeset pulp_rpm:454081e629a1df7e432b84e4fe025c1c1456e937.
Updated by Ichimonji10 about 7 years ago
- Status changed from MODIFIED to ASSIGNED
This fatal error is reported in the correct place. The RPM plugin incorrectly uses the progress report to report other errors. The best we can do for pulp2 is improve the error message itself.
Totally reasonable. As a result of this fix, the error message description should not be 'Unsupported scheme: ', correct?
In that case, this issue is fixed in 2.12, but is still broken in the 2.13 nightlies. The error message description returned by the 2.13 nightly builds on Jenkins is 'Unsupported scheme: '.
Updated by Ichimonji10 about 7 years ago
Re-tested against a matrix of nightly builds, where one axis is Pulp 2.12, 2.13 and 2.14, and the other axis is F24, F25 and RHEL 7. This issue is fixed for all matrix items. Here's the packages installed on one of the systems:
[root@fedora-24-pulp-2-12 ~]# rpm -qa | grep -i pulp | sort
pulp-admin-client-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
pulp-docker-admin-extensions-2.3.1-0.1.alpha.git.8.7464457.fc24.noarch
pulp-docker-plugins-2.3.1-0.1.alpha.git.8.7464457.fc24.noarch
pulp-ostree-admin-extensions-1.2.2-0.1.alpha.git.1.c56c4f1.fc24.noarch
pulp-ostree-plugins-1.2.2-0.1.alpha.git.1.c56c4f1.fc24.noarch
pulp-puppet-admin-extensions-2.12.3-0.1.alpha.git.7.bae5f67.fc24.noarch
pulp-puppet-plugins-2.12.3-0.1.alpha.git.7.bae5f67.fc24.noarch
pulp-python-admin-extensions-1.1.4-0.1.alpha.git.34.9c7f7e4.fc24.noarch
pulp-python-plugins-1.1.4-0.1.alpha.git.34.9c7f7e4.fc24.noarch
pulp-rpm-admin-extensions-2.12.3-0.1.alpha.git.9.a15e021.fc24.noarch
pulp-rpm-plugins-2.12.3-0.1.alpha.git.9.a15e021.fc24.noarch
pulp-selinux-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
pulp-server-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
python-kombu-3.0.33-6.pulp.fc24.noarch
python-pulp-bindings-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
python-pulp-client-lib-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
python-pulp-common-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
python-pulp-docker-common-2.3.1-0.1.alpha.git.8.7464457.fc24.noarch
python-pulp-oid_validation-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
python-pulp-ostree-common-1.2.2-0.1.alpha.git.1.c56c4f1.fc24.noarch
python-pulp-puppet-common-2.12.3-0.1.alpha.git.7.bae5f67.fc24.noarch
python-pulp-python-common-1.1.4-0.1.alpha.git.34.9c7f7e4.fc24.noarch
python-pulp-repoauth-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
python-pulp-rpm-common-2.12.3-0.1.alpha.git.9.a15e021.fc24.noarch
python-pulp-streamer-2.12.3-0.1.alpha.git.10.c3ccbe5.fc24.noarch
Updated by Ichimonji10 almost 7 years ago
- Status changed from ASSIGNED to MODIFIED
Updated by bizhang almost 7 years ago
- Project changed from Pulp to RPM Support
- Category deleted (
14) - Status changed from MODIFIED to CLOSED - CURRENTRELEASE
- Platform Release set to 2.12.2
The fix for this issue was released in 2.12.2, but the status was ASSIGNED at the time and it fell through the cracks
.
Better error message for invalid URL. closes #1376