Actions
Issue #1331
closedDocker v2 repositories cannot be deleted
Start date:
Due date:
Estimated time:
Severity:
3. High
Version - Docker:
master
Platform Release:
Target Release - Docker:
2.0.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:
Description
jluza alerted me to this issue in the docker_v2_api branch:
$ pulp-admin docker repo delete --repo-id registry
This command may be exited via ctrl+c without affecting the request.
[\]
Running...
Task Failed
Pulp exception occurred: PulpExecutionException
get_master_publish_dir() takes exactly 3 arguments (2 given)
get_export_repo_directory() takes exactly 2 arguments (1 given)
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) Error received removing distributor [docker_web_distributor_name_cli] from repo [registry]
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) Traceback (most recent call last):
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) File "/home/vagrant/devel/pulp/server/pulp/server/managers/repo/cud.py", line 241, in delete_repo
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) distributor_manager.remove_distributor(repo_id, repo_distributor['id'])
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) File "/home/vagrant/devel/pulp/server/pulp/server/managers/repo/distributor.py", line 241, in remove_distributor
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) distributor_instance.distributor_removed(transfer_repo, call_config)
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) File "/home/vagrant/devel/pulp_docker/plugins/pulp_docker/plugins/distributors/distributor_web.py", line 156, in distributor_removed
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) configuration.get_master_publish_dir(repo, config),
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) TypeError: get_master_publish_dir() takes exactly 3 arguments (2 given)
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) Error received removing distributor [docker_export_distributor_name_cli] from repo [registry]
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) Traceback (most recent call last):
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) File "/home/vagrant/devel/pulp/server/pulp/server/managers/repo/cud.py", line 241, in delete_repo
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) distributor_manager.remove_distributor(repo_id, repo_distributor['id'])
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) File "/home/vagrant/devel/pulp/server/pulp/server/managers/repo/distributor.py", line 241, in remove_distributor
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) distributor_instance.distributor_removed(transfer_repo, call_config)
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) File "/home/vagrant/devel/pulp_docker/plugins/pulp_docker/plugins/distributors/distributor_export.py", line 159, in distributor_removed
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) file_list = [os.path.join(configuration.get_export_repo_directory(config),
Oct 21 23:16:32 dev pulp[13135]: pulp.server.managers.repo.cud:ERROR: (13135-14080) TypeError: get_export_repo_directory() takes exactly 2 arguments (1 given)
jluza also provided a patch!
Actions
Fix repo deletion.
This commit fixes an issue where users were unable to delete docker repositories.
Thanks to Jindrich Luza for the report and for the fix!
https://pulp.plan.io/issues/1331
fixes #1331