Project

Profile

Help

Issue #1284

closed

pulp shouldn't update "last_publish" attribute when publish failed.

Added by jluza over 8 years ago. Updated about 5 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version:
2.6.3
Platform Release:
2.7.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

In publish process

https://github.com/pulp/pulp/blob/2.6-dev/server/pulp/server/managers/repo/publish.py#L139

There's strange line 139, where you set "last_publish" attribute although there had to occur some error in publish process. That means, "last_publish" is updated even if there could be something wrong with packages and therefore next publish will be fast-forward, however result of this publish doesn't have to be right.

Last publish attribute should be updated only when it's clear the publish finished successfully.

Also available in: Atom PDF