Project

Profile

Help

Issue #1284

pulp shouldn't update "last_publish" attribute when publish failed.

Added by jluza about 6 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version:
2.6.3
Platform Release:
2.7.0
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

In publish process

https://github.com/pulp/pulp/blob/2.6-dev/server/pulp/server/managers/repo/publish.py#L139

There's strange line 139, where you set "last_publish" attribute although there had to occur some error in publish process. That means, "last_publish" is updated even if there could be something wrong with packages and therefore next publish will be fast-forward, however result of this publish doesn't have to be right.

Last publish attribute should be updated only when it's clear the publish finished successfully.

History

#1 Updated by mhrivnak about 6 years ago

  • Priority changed from Normal to High
  • Platform Release set to 2.7.0
  • Triaged changed from No to Yes
  • Tags Easy Fix added

#2 Updated by jcline@redhat.com about 6 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to jcline@redhat.com

#3 Updated by jcline@redhat.com about 6 years ago

  • Status changed from ASSIGNED to 5

This actually got fixed by https://github.com/pulp/pulp/pull/1835 as part of https://pulp.plan.io/issues/214 and should be present in the current 2.7 beta.

#5 Updated by mhrivnak about 6 years ago

According to Jeremy, the fix for this was Jindra's proposal, to simply remove the single line that he referenced above. Thus the backport is to just remove that line. I'm assuming it's not worth everyone's time for us to hand-off an actual patch for that? Does that work for you? We can make the patch if it would be helpful.

#6 Updated by pthomas@redhat.com about 6 years ago

  • Status changed from 5 to 6

verified

[root@ibm-x3550m3-06 ~]# rpm -qa pulp-server
pulp-server-2.7.0-0.6.beta.el7.noarch
[root@ibm-x3550m3-06 ~]# 

#7 Updated by amacdona@redhat.com almost 6 years ago

  • Status changed from 6 to CLOSED - CURRENTRELEASE

#9 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF