Actions
Issue #1249
closedpulp_module_builder fails when there are no 'ModuleFile' metadata files
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.6.0
Platform Release:
2.6.5
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:
Description
- pulp-puppet-module-builder --url=file:///opt/puppet/repos/modules/
cd /opt/puppet
git clone --recursive file:///opt/puppet/repos/modules/
git status
find . -name Modulefile
find . -name metadata.json
puppet module build
Warning: Setting manifest is deprecated in puppet.conf. See http://links.puppetlabs.com/env-settings-deprecations
(at /usr/lib/ruby/site_ruby/1.8/puppet/settings.rb:1095:in `issue_deprecations')
Warning: Setting modulepath is deprecated in puppet.conf. See http://links.puppetlabs.com/env-settings-deprecations
(at /usr/lib/ruby/site_ruby/1.8/puppet/settings.rb:1095:in `issue_deprecations')
Error: Unable to find module root at /opt/puppet or parent directories
Error: Try 'puppet help module build' for usage
Line 229 of puppet_module_builder.py will return an empty line if there are no legacy ModuleFile metadata files (if for instance, you only have metadata.json metadata files)
set(['',
Which causes the 'puppet module build' to fail because it tries to build in the cwd.
Related issues
Actions
Fixes errors with repos without "Modulefile" modules.
Puppet repositories that contain modules that only use 'metadata.json' files or only 'Modulefile' files are now buildable by pulp-puppet-module-builder.
Closes #1249.