Issue #1229: Json config file values must be url encoded - Nectar - Pulp

Network maintenance. Planio will be observing two scheduled maintenance windows this Tuesday, March 2 and Wednesday, March 3 from 02:00 UTC until 06:00 UTC each in order to perform maintenance on access routers in our primary datacenter. Your account might observe short downtimes during these periods up to several minutes at a time.

Send by e-mail

Issue #1229

Json config file values must be url encoded

Added by ares over 5 years ago. Updated almost 2 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

High

Assignee:

ipanova@redhat.com

Start date:

Due date:

Estimated time:

Severity:

2. Medium

Version - Nectar:

1.3.1

Platform Release:

Target Release - Nectar:

1.4.4

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Easy Fix, Pulp 2

Sprint:

Quarter:

Description

It was reported that when pulp is configured through katello-installer and user specifies a value for proxy-user or proxy-password parameter, it's propagated to
/etc/pulp/server/plugins.conf.d/yum_importer.json (and other similar files) without being url encoded. I suspect that the need of using url encoded values is actually a pulp issue, wherever the json is used, pulp should encode it according to context. An example of failing value is "passw?rd" which needs to be converted to "passw%24rd". While we could likely make katello-installer encode the value in this file, if you later change this, it would break again.

For additional information, see https://bugzilla.redhat.com/show_bug.cgi?id=1180637. Just note that it combines actually two issues (shell escaping or installer arguments is separate issue).