Project

Profile

Help

Issue #1218

closed

pulp/plugins/util/publish_step.py may call report_progress too often

Added by mihai.ibanescu@gmail.com almost 7 years ago. Updated about 3 years ago.

Status:
CLOSED - WONTFIX
Priority:
Normal
Assignee:
-
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
1. Low
Version:
2.7.0 Beta
Platform Release:
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Easy Fix, Pulp 2
Sprint:
Quarter:

Description

report_progress has the following:

else:
    current_time = time.time()
    if current_time != self.last_report_time:
        # Update at most once a second
        self.get_status_conduit().set_progress(self.get_progress_report())
        self.last_report_time = current_time

Since time.time() returns fractions of seconds, that comment is incorrect - it may call set_progress() more than once a second.

I would recommend:

if current_time - self.last_report_time > 1:

Also available in: Atom PDF