Issue #1218: pulp/plugins/util/publish_step.py may call report_progress too often - Pulp

Actions

Send by e-mail Copy link

Issue #1218

closed

pulp/plugins/util/publish_step.py may call report_progress too often

Added by mihai.ibanescu@gmail.com over 8 years ago. Updated about 5 years ago.

Status:

CLOSED - WONTFIX

Priority:

Normal

Assignee:

-

Category:

-

Sprint/Milestone:

-

Start date:

Due date:

Estimated time:

Severity:

1. Low

Version:

2.7.0 Beta

Platform Release:

OS:

Triaged:

Yes

Groomed:

No

Sprint Candidate:

No

Tags:

Easy Fix, Pulp 2

Sprint:

Quarter:

Description

report_progress has the following:

else:
    current_time = time.time()
    if current_time != self.last_report_time:
        # Update at most once a second
        self.get_status_conduit().set_progress(self.get_progress_report())
        self.last_report_time = current_time

Since time.time() returns fractions of seconds, that comment is incorrect - it may call set_progress() more than once a second.

I would recommend:

if current_time - self.last_report_time > 1:

Actions

#1

Updated by mhrivnak over 8 years ago

Triaged changed from No to Yes

Actions

#2

Updated by bmbouter about 5 years ago

Status changed from NEW to CLOSED - WONTFIX

Actions

#3

Updated by bmbouter about 5 years ago

Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the developer mailing list.

Actions

#4

Updated by bmbouter about 5 years ago

Tags Pulp 2 added

Actions

Send by e-mail Copy link

Also available in: Atom PDF