https://pulp.plan.io/https://pulp.plan.io/favicon.ico2015-07-17T15:02:47ZPulpPulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=55922015-07-17T15:02:47Zjortel@redhat.comjortel@redhat.com
<ul><li><strong>Tracker</strong> changed from <i>Issue</i> to <i>Refactor</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li><li><strong>Groomed</strong> set to <i>No</i></li><li><strong>Sprint Candidate</strong> set to <i>No</i></li></ul><p>Investigate to see if the class in pulp_rpm can be removed and the plugin refactored to use the one in platform. If this is the case, change the project on this issue to PULP_RPM.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=93622016-02-25T14:13:41Zbmbouterbmbouter@redhat.com
<ul><li><strong>Parent issue</strong> set to <i>#1683</i></li></ul> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=102922016-03-31T14:36:36Zmhrivnakmhrivnak@redhat.com
<ul><li><strong>Sprint/Milestone</strong> set to <i>19</i></li></ul> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=104672016-04-08T14:54:58Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>ASSIGNED</i></li><li><strong>Assignee</strong> set to <i>semyers</i></li></ul><p>/me puts on a deerstalker cap and begins to investigate</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=111682016-05-02T15:30:03Zmhrivnakmhrivnak@redhat.com
<ul><li><strong>Sprint/Milestone</strong> changed from <i>19</i> to <i>20</i></li></ul> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=111932016-05-02T19:22:55Zsemyerssean.myers@redhat.com
<ul></ul><p>Since both classes are actually in-use, and also both have subclasses, I'm bringing the newer behavior from pulp_rpm back into platform and making the pulp_rpm version be a subclass of it that contains the tiny slice of yum-specific behavior that has been added to pulp_rpm.</p>
<p>It looks trivial to maintain backward-compatibility, so existing calls to this class and its subclasses in pulp_rpm won't need to be modified to adapt to the changes I'm making.</p>
<p>In addition to repetition in these two classes, many tests have been duplicated. I'm also going through an auditing those to similarly DRY things up.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=111942016-05-02T19:23:29Zsemyerssean.myers@redhat.com
<ul></ul><p>Ah, and I forgot to mention that this change will require two PRs, one for platform and one for RPM.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=111982016-05-02T22:50:53Zsemyerssean.myers@redhat.com
<ul></ul><p>semyers wrote:</p>
<blockquote>
<p>In addition to repetition in these two classes, many tests have been duplicated. I'm also going through an auditing those to similarly DRY things up.</p>
</blockquote>
<p>Naturally, this is the part that's taking the most time :(</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=114452016-05-12T18:44:16Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>POST</i></li></ul><p>Platform PR:<br>
<a href="https://github.com/pulp/pulp/pull/2565" class="external">https://github.com/pulp/pulp/pull/2565</a></p>
<p>RPM branch that can be a PR once the platform PR is merged:<br>
<a href="https://github.com/pulp/pulp_rpm/compare/master...seandst:rm1142" class="external">https://github.com/pulp/pulp_rpm/compare/master...seandst:rm1142</a></p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=120072016-06-02T13:20:25Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>POST</i> to <i>MODIFIED</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Refector to use MetadataFileContext from platform fixes #1142 https://pulp.plan.io/issues/1142" href="https://pulp.plan.io/projects/pulp_rpm/repository/9/revisions/eb322da7f849cd4bb9fa342149a998c8fe2265a6">pulp_rpm:eb322da7f849cd4bb9fa342149a998c8fe2265a6</a>.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=120092016-06-02T13:37:01Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>MODIFIED</i> to <i>ASSIGNED</i></li></ul><p>My changes broke master, so I'll need to tone this down a little bit. It looked like changing some method 'pass'es to raising a notimplementederror was particularly rude.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=129892016-07-13T23:05:48Zsemyerssean.myers@redhat.com
<ul><li><strong>Status</strong> changed from <i>ASSIGNED</i> to <i>NEW</i></li><li><strong>Assignee</strong> deleted (<del><i>semyers</i></del>)</li></ul><p>Sorry to drop this, but I don't think I'll be able to get to it in the immediate future.</p>
<p>These changes passed unit tests but broke pulp-smash, so some more work is needed to consolidate the common behavior into platform.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=144112016-09-12T18:07:06Zbmbouterbmbouter@redhat.com
<ul><li><strong>Sprint/Milestone</strong> deleted (<del><i>20</i></del>)</li></ul><p>Unsetting the sprint since it is not currently being worked on.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=195262017-05-08T18:15:31Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>RCM</i> added</li></ul> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=366622019-04-12T19:17:07Zbmbouterbmbouter@redhat.com
<ul><li><strong>Status</strong> changed from <i>NEW</i> to <i>CLOSED - WONTFIX</i></li></ul> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=366852019-04-12T19:20:07Zbmbouterbmbouter@redhat.com
<ul></ul><p>Pulp 2 is approaching maintenance mode, and this Pulp 2 ticket is not being actively worked on. As such, it is being closed as WONTFIX. Pulp 2 is still accepting contributions though, so if you want to contribute a fix for this ticket, please reopen or comment on it. If you don't have permissions to reopen this ticket, or you want to discuss an issue, please reach out via the <a href="https://www.redhat.com/mailman/listinfo/pulp-dev" class="external">developer mailing list</a>.</p> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=396732019-04-15T20:45:36Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> <i>Pulp 2</i> added</li></ul> Pulp - Refactor #1142: MetadataFileContext in pulp and pulp_rpmhttps://pulp.plan.io/issues/1142?journal_id=434242019-05-03T14:05:25Zbmbouterbmbouter@redhat.com
<ul><li><strong>Tags</strong> deleted (<del><i>RCM</i></del>)</li></ul>