Project

Profile

Help

Issue #1097

Canceling a task results in a traceback

Added by bmbouter over 6 years ago. Updated over 2 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
High
Assignee:
Category:
-
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
2. Medium
Version:
2.4.4
Platform Release:
2.6.5
OS:
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

To reproduce:
1) Create a repo and sync it
2) while it is syncing cancel the sync task
3) observe the traceback below

pulp: pulp.server.async.tasks:INFO: Task canceled: 9274b76a-eb1f-49bf-a0c5-2358b8bef3ec.
pulp: celery.worker.control:INFO: Terminating 9274b76a-eb1f-49bf-a0c5-2358b8bef3ec (15)
pulp: pulp.server.managers.repo.publish:ERROR: Exception caught from plugin during publish for repo [MyOrg-Library-RHEL_6_6_Server_01_04_2015-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6Server]
pulp: pulp.server.managers.repo.publish:ERROR: Traceback (most recent call last):
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp/server/managers/repo/publish.py", line 126, in _do_publish
pulp: pulp.server.managers.repo.publish:ERROR:     publish_report = publish_repo(transfer_repo, conduit, call_config)
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp/server/async/tasks.py", line 458, in wrap_f
pulp: pulp.server.managers.repo.publish:ERROR:     return f(*args, **kwargs)     
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp_node/distributors/http/distributor.py", line 126, in publish_repo
pulp: pulp.server.managers.repo.publish:ERROR:     publisher.publish(units)
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp_node/distributors/http/publisher.py", line 50, in publish
pulp: pulp.server.managers.repo.publish:ERROR:     manifest_path = super(self.__class__, self).publish(units)
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp_node/distributors/publisher.py", line 129, in publish
pulp: pulp.server.managers.repo.publish:ERROR:     writer.add(unit)
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp_node/manifest.py", line 349, in add
pulp: pulp.server.managers.repo.publish:ERROR:     json_unit = json.dumps(unit)  
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib64/python2.6/json/__init__.py", line 230, in dumps
pulp: pulp.server.managers.repo.publish:ERROR:     return _default_encoder.encode(obj)
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib64/python2.6/json/encoder.py", line 367, in encode
pulp: pulp.server.managers.repo.publish:ERROR:     chunks = list(self.iterencode(o))
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib64/python2.6/json/encoder.py", line 309, in _iterencode
pulp: pulp.server.managers.repo.publish:ERROR:     for chunk in self._iterencode_dict(o, markers):
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib64/python2.6/json/encoder.py", line 275, in _iterencode_dict 
pulp: pulp.server.managers.repo.publish:ERROR:     for chunk in self._iterencode(value, markers):
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib64/python2.6/json/encoder.py", line 309, in _iterencode
pulp: pulp.server.managers.repo.publish:ERROR:     for chunk in self._iterencode_dict(o, markers):
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib64/python2.6/json/encoder.py", line 276, in _iterencode_dict 
pulp: pulp.server.managers.repo.publish:ERROR:     yield chunk
pulp: pulp.server.managers.repo.publish:ERROR:   File "/usr/lib/python2.6/site-packages/pulp/server/async/tasks.py", line 441, in sigterm_handler
pulp: pulp.server.managers.repo.publish:ERROR:     handler()
pulp: pulp.server.managers.repo.publish:ERROR: TypeError: cancel_publish_repo() takes exactly 3 arguments (1 given) 
pulp: celery.worker.job:ERROR: Task pulp.server.managers.repo.publish.publish[9274b76a-eb1f-49bf-a0c5-2358b8bef3ec] raised unexpected: TypeError('cancel_publish_repo() takes exactly 3 arguments (1 given)',)

Associated revisions

Revision 351fcc56 View on GitHub
Added by sbhawsin over 6 years ago

Issue 1097: Cancelling a task while sync

https://pulp.plan.io/issues/1097

closes #1097

Revision 351fcc56 View on GitHub
Added by sbhawsin over 6 years ago

Issue 1097: Cancelling a task while sync

https://pulp.plan.io/issues/1097

closes #1097

History

#1 Updated by mhrivnak over 6 years ago

  • Priority changed from Normal to High
  • Triaged changed from No to Yes

Hopefully this will only require confirming that this traceback does not occur with 2.6 during an rpm publish.

#2 Updated by mhrivnak over 6 years ago

Offending line: https://github.com/pulp/pulp/blob/2.4-release/nodes/parent/pulp_node/distributors/http/distributor.py#L147

The signature is incorrect. It should take no arguments except for "self".

#3 Updated by sbhawsin over 6 years ago

  • Status changed from NEW to POST
  • Assignee set to sbhawsin
  • Platform Release set to master

#4 Updated by sbhawsin over 6 years ago

  • Platform Release changed from master to 2.6.0

#5 Updated by bmbouter over 6 years ago

  • Platform Release changed from 2.6.0 to 2.6.4

Currently 2.6-dev corresponds with the 2.6.4 release.

#6 Updated by sbhawsin over 6 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100

#7 Updated by dkliban@redhat.com about 6 years ago

  • Platform Release changed from 2.6.4 to 2.6.5

#8 Updated by dkliban@redhat.com about 6 years ago

  • Status changed from MODIFIED to 5

#9 Updated by dkliban@redhat.com about 6 years ago

  • Status changed from 5 to CLOSED - CURRENTRELEASE

#10 Updated by bmbouter over 2 years ago

  • Tags Pulp 2 added

Please register to edit this issue

Also available in: Atom PDF