Project

Profile

Help

Issue #1074

closed

Failing to specify an auto-publish value results in a null value

Added by jcline@redhat.com about 7 years ago. Updated over 3 years ago.

Status:
CLOSED - CURRENTRELEASE
Priority:
Normal
Sprint/Milestone:
-
Start date:
Due date:
Estimated time:
Severity:
3. High
Version - OSTree:
master
Platform Release:
Target Release - OSTree:
1.0.0
OS:
Fedora 21
Triaged:
Yes
Groomed:
No
Sprint Candidate:
No
Tags:
Pulp 2
Sprint:
Quarter:

Description

The CLI documentation states the --auto-publish value defaults to 'true' when you create a new ostree repository:

(pulp)[vagrant@pulp-devel pulp_ostree]$ pulp-admin ostree repo create --help
Command: create
Description: creates a new repository

Available Arguments:
...
  --auto-publish  - if "true", on each successful sync the repository will
                    automatically be published; if "false" content will only be
                    available after manually publishing the repository; defaults
                    to "true"

However if you don't provide a value explicitly the actual default is null:

{
    "_ns": "repo_distributors",
    "auto_publish": null,
    "config": {
        "relative_path": "/repo/"
    },
    "distributor_type_id": "ostree_web_distributor",
    "id": "ostree_web_distributor_name_cli",
    "last_publish": null,
    "repo_id": "test",
    "scheduled_publishes": [],
    "scratchpad": null
}

This results in no auto-publishes

Actions #1

Updated by bmbouter about 7 years ago

  • Severity changed from 2. Medium to 3. High
  • Triaged changed from No to Yes

Both a CLI and a server side issue. Please fix in both places.

Actions #2

Updated by ipanova@redhat.com about 7 years ago

  • Status changed from NEW to ASSIGNED
  • Assignee set to ipanova@redhat.com

Added by ipanova@redhat.com about 7 years ago

Revision 8db30a78

Auto-publish now default to true.

closes #1074 https://pulp.plan.io/issues/1074

Actions #3

Updated by ipanova@redhat.com about 7 years ago

  • Status changed from ASSIGNED to POST

https://github.com/pulp/pulp_ostree/pull/36

Issue was only in CLI.

Server side did not have any issues - if auto_publish was not specified at all , then in config it was False
- if auto_publish was specified and value was True, then in config it was True

This way work other content types, I specifically checked the rpm repo creation behaviour via API.

Actions #4

Updated by ipanova@redhat.com about 7 years ago

  • Status changed from POST to MODIFIED
  • % Done changed from 0 to 100
Actions #5

Updated by jortel@redhat.com almost 7 years ago

  • Target Release - OSTree set to 1.0.0
Actions #6

Updated by rbarlow over 6 years ago

  • Status changed from MODIFIED to CLOSED - CURRENTRELEASE
Actions #7

Updated by bmbouter over 3 years ago

  • Tags Pulp 2 added

Also available in: Atom PDF