Issue #1042: Exception raised when building error message on relative_url collision - RPM Support - Pulp

Actions

Send by e-mail Copy link

Issue #1042

closed

Exception raised when building error message on relative_url collision

Added by bcourt almost 9 years ago. Updated about 5 years ago.

Status:

CLOSED - CURRENTRELEASE

Priority:

High

Assignee:

ipanova@redhat.com

Sprint/Milestone:

Start date:

Due date:

Estimated time:

Severity:

3. High

Version:

2.6.1

Platform Release:

2.6.5

OS:

Triaged:

Yes

Groomed:

Sprint Candidate:

Tags:

Easy Fix, Pulp 2

Sprint:

Quarter:

Description

If a repo is created using a relative_url

The line https://github.com/pulp/pulp_rpm/blob/pulp-rpm-2.6.1-1/plugins/pulp_rpm/plugins/distributors/yum/configuration.py#L469
is checking which will raise a KeyError if 'relative_url' has not been defined in the distributor config.

conflicting_relative_url = distributor['config']['relative_url'] or conflicting_repo_id

This should be replaced with something like

if 'relative_url' in distributor['config']:
    conflicting_relative_url = distributor['config']['relative_url'] or conflicting_repo_id
else:
    conflicting_relative_url = conflicting_repo_id

Actions

Copy link

Updated by bcourt almost 9 years ago

Severity changed from 2. Medium to 3. High

Raising severity to high as this prevents the user from seeing the reason an error is being raised.

Actions

Copy link

Updated by mhrivnak almost 9 years ago

Priority changed from Normal to High
Triaged changed from No to Yes
Tags Easy Fix added

Please add verification steps.

Actions

Copy link

Updated by ipanova@redhat.com almost 9 years ago

Status changed from NEW to ASSIGNED

Actions

Copy link

Updated by ipanova@redhat.com almost 9 years ago

Assignee set to ipanova@redhat.com

Actions

Copy link

Updated by ipanova@redhat.com almost 9 years ago

Status changed from ASSIGNED to POST

https://github.com/pulp/pulp_rpm/pull/700

Added by ipanova@redhat.com almost 9 years ago

Revision 1465d905 | View on GitHub

Exception raised when building error message on relative_url collision

closes #1042 https://pulp.plan.io/issues/1042

It turns out that pulp complains not only for relative_url collision of another relative_url repo, but also for relative_url collision with repo id of existing repo.

Due to this behaviour pulp renders incorrect and false message.

Actions

Copy link